anishshri-db commented on code in PR #50612:
URL: https://github.com/apache/spark/pull/50612#discussion_r2049642043
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDDSuite.scala:
##########
@@ -227,6 +228,32 @@ class StateStoreRDDSuite extends SparkFunSuite with
BeforeAndAfter {
}
}
+ test("SPARK-XXXXX: unload on commit") {
Review Comment:
Can we add the actual SPARK ticket number here ?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2519,6 +2519,16 @@ object SQLConf {
.stringConf
.createWithDefault(CompressionCodec.LZ4)
+ val STATE_STORE_UNLOAD_ON_COMMIT =
+ buildConf("spark.sql.streaming.stateStore.unloadOnCommit")
+ .internal()
+ .doc("When true, Spark will synchronously run maintenance and then close
each StateStore " +
+ "instance on task completion. This reduce overhead involved in keeping
every StateStore " +
Review Comment:
nit: `reduces overhead in`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
