anishshri-db commented on code in PR #50600:
URL: https://github.com/apache/spark/pull/50600#discussion_r2047890734
##########
python/pyspark/sql/tests/connect/pandas/test_parity_pandas_transform_with_state.py:
##########
@@ -53,6 +55,37 @@ def test_schema_evolution_scenarios(self):
pass
+# TODO: need to unblock once we implement transformWithState in Python Spark
Connect
Review Comment:
Should we remove till then ?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StateDataSource.scala:
##########
@@ -55,7 +55,11 @@ class StateDataSource extends TableProvider with
DataSourceRegister with Logging
// Seq of operator names who uses state schema v3 and TWS related options.
// This Seq was used in checks before reading state schema files.
- private val twsShortNameSeq = Seq("transformWithStateExec",
"transformWithStateInPandasExec")
+ private val twsShortNameSeq = Seq(
+ "transformWithStateExec",
+ "transformWithStateInPandasExec",
+ "transformWithStateInPySparkExec"
Review Comment:
Can we add tests for the state source reader with the new interface also ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
