beliefer commented on code in PR #50636:
URL: https://github.com/apache/spark/pull/50636#discussion_r2050406896
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala:
##########
@@ -293,19 +293,23 @@ trait JoinSelectionHelper extends Logging {
join: Join,
hintOnly: Boolean,
conf: SQLConf): Option[BuildSide] = {
- val buildLeft = if (hintOnly) {
- hintToBroadcastLeft(join.hint)
- } else {
- canBroadcastBySize(join.left, conf) && !hintToNotBroadcastLeft(join.hint)
+ def maybeBuildLeft(): Boolean = {
Review Comment:
`buildLeft` seems wired if it is used as function. It seems we build
something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
