cloud-fan commented on code in PR #50455:
URL: https://github.com/apache/spark/pull/50455#discussion_r2049935287
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala:
##########
@@ -304,8 +304,8 @@ trait JoinSelectionHelper extends Logging {
canBroadcastBySize(join.right, conf) &&
!hintToNotBroadcastRight(join.hint)
}
getBuildSide(
- canBuildBroadcastLeft(join.joinType) && buildLeft,
Review Comment:
This PR reminds me that `buildLeft` is not actually cheap to calculate,
likely more expensive than `canBuildBroadcastLeft` invocation.
Shall we turn `buildLeft/buildRight` into lazy val and revert the order here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
