mihailotim-db commented on code in PR #50606:
URL: https://github.com/apache/spark/pull/50606#discussion_r2048385309
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -1825,24 +1825,32 @@ class AstBuilder extends DataTypeAstBuilder
}
visitNamedExpression(n)
}.toSeq
+ val groupByExpressionsWithReplacedOrdinals =
+ replaceOrdinalsInGroupingExpressions(groupByExpressions)
if (ctx.GROUPING != null) {
// GROUP BY ... GROUPING SETS (...)
// `groupByExpressions` can be non-empty for Hive compatibility. It
may add extra grouping
// expressions that do not exist in GROUPING SETS (...), and the value
is always null.
// For example, `SELECT a, b, c FROM ... GROUP BY a, b, c GROUPING
SETS (a, b)`, the output
// of column `c` is always null.
val groupingSets =
- ctx.groupingSet.asScala.map(_.expression.asScala.map(e =>
expression(e)).toSeq)
- Aggregate(Seq(GroupingSets(groupingSets.toSeq, groupByExpressions)),
+ ctx.groupingSet.asScala.map(_.expression.asScala.map(e => {
Review Comment:
Done! I moved to a separate method with a scaladoc instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
