aokolnychyi commented on code in PR #50593:
URL: https://github.com/apache/spark/pull/50593#discussion_r2045800403
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ColumnDefaultValue.java:
##########
@@ -68,16 +64,20 @@ public Literal<?> getValue() {
public boolean equals(Object o) {
if (this == o) return true;
if (!(o instanceof ColumnDefaultValue that)) return false;
- return sql.equals(that.sql) && value.equals(that.value);
+ return Objects.equals(getSql(), that.getSql()) &&
+ Objects.equals(getExpression(), that.getExpression()) &&
+ value.equals(that.value);
}
@Override
public int hashCode() {
- return Objects.hash(sql, value);
+ return Objects.hash(getSql(), getExpression(), value);
}
@Override
public String toString() {
- return "ColumnDefaultValue{sql='" + sql + "\', value=" + value + '}';
+ return String.format(
+ "ColumnDefaultValue{sql=%s, expression=%s, value=%s}",
Review Comment:
I removed `''` around sql. We had double quotes for strings. Int literals
also showed up as string literals.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
