hiufung-kwok commented on code in PR #50586:
URL: https://github.com/apache/spark/pull/50586#discussion_r2045783489
##########
core/benchmarks/KryoBenchmark-jdk21-results.txt:
##########
@@ -2,27 +2,27 @@
Benchmark Kryo Unsafe vs safe Serialization
================================================================================================
-OpenJDK 64-Bit Server VM 21.0.6+7-LTS on Linux 6.8.0-1020-azure
+OpenJDK 64-Bit Server VM 21.0.6+7-LTS on Linux 6.8.0-1021-azure
AMD EPYC 7763 64-Core Processor
Benchmark Kryo Unsafe vs safe Serialization: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
---------------------------------------------------------------------------------------------------------------------------
-basicTypes: Int with unsafe:true 166 168
3 6.0 165.5 1.0X
-basicTypes: Long with unsafe:true 178 182
5 5.6 178.2 0.9X
-basicTypes: Float with unsafe:true 185 189
6 5.4 184.9 0.9X
-basicTypes: Double with unsafe:true 183 188
9 5.5 183.2 0.9X
-Array: Int with unsafe:true 1 1
0 763.7 1.3 126.4X
-Array: Long with unsafe:true 2 2
0 447.3 2.2 74.1X
-Array: Float with unsafe:true 1 1
0 753.7 1.3 124.8X
-Array: Double with unsafe:true 2 2
0 457.5 2.2 75.7X
-Map of string->Double with unsafe:true 28 28
0 36.2 27.6 6.0X
-basicTypes: Int with unsafe:false 203 204
1 4.9 203.1 0.8X
-basicTypes: Long with unsafe:false 223 224
1 4.5 222.8 0.7X
-basicTypes: Float with unsafe:false 206 207
1 4.9 205.8 0.8X
-basicTypes: Double with unsafe:false 204 205
1 4.9 204.1 0.8X
-Array: Int with unsafe:false 13 13
0 79.5 12.6 13.2X
-Array: Long with unsafe:false 21 22
1 46.6 21.5 7.7X
-Array: Float with unsafe:false 13 13
0 78.6 12.7 13.0X
-Array: Double with unsafe:false 15 15
0 67.8 14.8 11.2X
-Map of string->Double with unsafe:false 28 30
1 35.3 28.3 5.8X
+basicTypes: Int with unsafe:true 166 169
6 6.0 165.7 1.0X
+basicTypes: Long with unsafe:true 178 182
4 5.6 177.5 0.9X
+basicTypes: Float with unsafe:true 183 191
9 5.5 182.7 0.9X
+basicTypes: Double with unsafe:true 186 193
7 5.4 186.4 0.9X
+Array: Int with unsafe:true 1 1
0 745.8 1.3 123.5X
+Array: Long with unsafe:true 2 3
0 451.7 2.2 74.8X
+Array: Float with unsafe:true 1 1
0 743.0 1.3 123.1X
+Array: Double with unsafe:true 2 2
0 475.6 2.1 78.8X
+Map of string->Double with unsafe:true 27 28
1 37.0 27.0 6.1X
+basicTypes: Int with unsafe:false 198 199
1 5.1 197.7 0.8X
+basicTypes: Long with unsafe:false 220 221
1 4.5 219.8 0.8X
+basicTypes: Float with unsafe:false 206 208
1 4.8 206.3 0.8X
+basicTypes: Double with unsafe:false 222 225
2 4.5 221.9 0.7X
+Array: Int with unsafe:false 13 14
1 78.0 12.8 12.9X
+Array: Long with unsafe:false 21 21
1 48.2 20.8 8.0X
+Array: Float with unsafe:false 6 6
0 178.9 5.6 29.6X
Review Comment:
Double in throughput 🤔
Are we are expecting this kind of improvement on a hotfix bump I wonder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
