HeartSaVioR commented on code in PR #50559: URL: https://github.com/apache/spark/pull/50559#discussion_r2045581330
########## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBCheckpointFailureInjectionSuite.scala: ########## @@ -475,14 +475,14 @@ class RocksDBCheckpointFailureInjectionSuite extends StreamTest additionalConfs = additionalConfs), AddData(inputData, 4), if (failureConf.logType == "commits") { - // If the failure is in the commit log, data is already committed. The batch will - // rerun but the comit will be no-op. - CheckLastBatch((3, 3), (1, 1), (4, 1)) + // If the failure is in the commit log, data is already committed. + // MemorySink isn't a EactlyOnce sink, so we will see the data from the previous Review Comment: ```suggestion // MemorySink isn't an ExactlyOnce sink, so we will see the data from the previous ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org