cloud-fan commented on code in PR #50333:
URL: https://github.com/apache/spark/pull/50333#discussion_r2043844308
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -499,6 +507,14 @@ abstract class JdbcDialect extends Serializable with
Logging {
@Since("3.3.0")
def isSupportedFunction(funcName: String): Boolean = false
+ /**
+ * Returns whether the database supports extract.
+ * @param extract The V2 Extract to be converted.
+ * @return True if the database supports extract.
+ */
+ @Since("4.1.0")
+ def isSupportedExtract(extract: Extract): Boolean = false
Review Comment:
I think we are making the API overly complicated. Too many knobs. It looks
fine to ask the implementation to override `visitExtract` carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
