cloud-fan commented on code in PR #50562:
URL: https://github.com/apache/spark/pull/50562#discussion_r2043819775
##########
sql/hive/src/test/scala/org/apache/spark/sql/sources/SimpleTextRelation.scala:
##########
@@ -33,7 +33,7 @@ import org.apache.spark.util.ArrayImplicits._
import org.apache.spark.util.SerializableConfiguration
import org.apache.spark.util.Utils
-class SimpleTextSource extends TextBasedFileFormat with DataSourceRegister {
+case class SimpleTextSource() extends TextBasedFileFormat with
DataSourceRegister {
Review Comment:
```suggestion
private[sql] case class SimpleTextSource() extends TextBasedFileFormat with
DataSourceRegister {
```
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala:
##########
@@ -55,16 +55,12 @@ import org.apache.spark.util.SerializableConfiguration
* `FileFormat` for reading ORC files. If this is moved or renamed, please
update
* `DataSource`'s backwardCompatibilityMap.
*/
-class OrcFileFormat extends FileFormat with DataSourceRegister with
Serializable {
+case class OrcFileFormat() extends FileFormat with DataSourceRegister with
Serializable {
Review Comment:
```suggestion
private[sql] case class OrcFileFormat() extends FileFormat with
DataSourceRegister with Serializable {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
