yaooqinn commented on code in PR #58: URL: https://github.com/apache/spark-connect-swift/pull/58#discussion_r2043405612
########## Tests/SparkConnectTests/DataFrameReaderTests.swift: ########## @@ -85,4 +85,27 @@ struct DataFrameReaderTests { }) await spark.stop() } + + @Test + func schema() async throws { + let spark = try await SparkSession.builder.getOrCreate() + let path = "../examples/src/main/resources/people.json" + #expect(try await spark.read.schema("age SHORT").json(path).dtypes.count == 1) + #expect(try await spark.read.schema("age SHORT").json(path).dtypes[0] == ("age", "smallint")) + #expect(try await spark.read.schema("age SHORT, name STRING").json(path).dtypes[0] == ("age", "smallint")) + #expect(try await spark.read.schema("age SHORT, name STRING").json(path).dtypes[1] == ("name", "string")) Review Comment: Can we also add a test with comment & null constraint -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org