HeartSaVioR commented on code in PR #50550:
URL: https://github.com/apache/spark/pull/50550#discussion_r2042211677
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##########
@@ -2358,4 +2382,50 @@ class TransformWithStateValidationSuite extends
StateStoreMetricsTest {
assert(ex1.getMessage.contains("Failed to find time values"))
TransformWithStateVariableUtils.validateTimeMode(TimeMode.EventTime(),
Some(10L))
}
+
+ Seq(TimeMode.None(), TimeMode.ProcessingTime()).foreach { timeMode =>
+ test("transformWithState - using watermark but time mode as None should
not perform " +
Review Comment:
nit: `time mode as None` is not the same with timeMode=$timeMode`
why not just `transformWithState - using watermark but time mode as
$timeMode should not perform late record filtering` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
