LuciferYang commented on code in PR #50574: URL: https://github.com/apache/spark/pull/50574#discussion_r2041319923
########## .github/workflows/python_hosted_runner_test.yml: ########## @@ -152,12 +167,12 @@ jobs: if: always() uses: actions/upload-artifact@v4 with: - name: test-results-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3-${{ env.PYTHON_TO_TEST }} + name: test-results-${{ inputs.os }}-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3-${{ env.PYTHON_TO_TEST }} Review Comment: This change is made to facilitate the distinction of the results uploaded by the `pyspark` task in `build_and_test` during manual testing. If it needs to be split into a separate pull request, please let me know. ########## .github/workflows/python_hosted_runner_test.yml: ########## @@ -152,12 +167,12 @@ jobs: if: always() uses: actions/upload-artifact@v4 with: - name: test-results-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3-${{ env.PYTHON_TO_TEST }} + name: test-results-${{ inputs.os }}-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3-${{ env.PYTHON_TO_TEST }} path: "**/target/test-reports/*.xml" - name: Upload unit tests log files env: ${{ fromJSON(inputs.envs) }} if: ${{ !success() }} uses: actions/upload-artifact@v4 with: - name: unit-tests-log-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3-${{ env.PYTHON_TO_TEST }} + name: unit-tests-log-${{ inputs.os }}-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3-${{ env.PYTHON_TO_TEST }} Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org