ueshin commented on code in PR #50466:
URL: https://github.com/apache/spark/pull/50466#discussion_r2040453795
##########
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala:
##########
@@ -401,33 +415,35 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
}
}.start()
}
- val secret = if (isBarrier) {
- authHelper.secret
- } else {
- ""
- }
if (isBarrier) {
// Close ServerSocket on task completion.
- serverSocket.foreach { server =>
- context.addTaskCompletionListener[Unit](_ => server.close())
+ serverSocketChannel.foreach { server =>
+ context.addTaskCompletionListener[Unit] { _ =>
+ server.close()
+ if (isUnixDomainSock) sockPath.deleteOnExit()
Review Comment:
Do we still need to call `sockPath.deleteOnExit()`? It's already called at
[line
367](https://github.com/apache/spark/pull/50466/files#diff-ed4fb5ce30273e8eefcc7d4b0152ea7a60fb4f8f709d4da8ea1ab56aeda26001R367)?
Or it should be `sockPath.delete()` instead? May want to consider to use
`Files.deleteIfExists`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
