ueshin commented on code in PR #50470:
URL: https://github.com/apache/spark/pull/50470#discussion_r2040085100
##########
sql/api/src/main/scala/org/apache/spark/sql/Column.scala:
##########
@@ -803,6 +803,26 @@ class Column(val node: ColumnNode) extends Logging with
TableValuedFunctionArgum
*/
def isInCollection(values: java.lang.Iterable[_]): Column =
isInCollection(values.asScala)
+ /**
+ * A boolean expression that is evaluated to true if the value of this
expression is contained
+ * by the provided Dataset/DataFrame.
+ *
+ * @group subquery
+ * @since 4.1.0
+ */
+ def isin(ds: Dataset[_]): Column = {
+ if (ds == null) {
Review Comment:
The SQL equivalent is:
```sql
col IN (NULL)
```
For the API, previously `col.isin(null)` invokes `def isin(list: Any*):
Column` but now `def isin(ds: Dataset[_]): Column`, so it needs to call the
original one explicitly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
