cloud-fan commented on code in PR #50552:
URL: https://github.com/apache/spark/pull/50552#discussion_r2039125858
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##########
@@ -183,7 +183,8 @@ abstract class OffsetWindowFunctionFrameBase(
override def prepare(rows: ExternalAppendOnlyUnsafeRowArray): Unit = {
resetStates(rows)
if (absOffset > rows.length) {
- fillDefaultValue(EmptyRow)
Review Comment:
Is it the only place? Seems we should never run `fillDefaultValue` in
`prepare` as the default value can be an expression that references attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
