micheal-o commented on PR #50512: URL: https://github.com/apache/spark/pull/50512#issuecomment-2788129812
> Only minors. Btw, will this be also applied to checkpoint v2? I'm not very sure about snapshot being reused here when checkpoint v2 is used (it should follow the lineage). @HeartSaVioR Checkpoint v2 is already using SST file reuse. Every SST file has a unique name in DFS and we compare during load that the DFS file name recorded in the snapshot metadata file is the same as the local one before reusing it. See [this](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala#L759) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
