LuciferYang commented on code in PR #49: URL: https://github.com/apache/spark-connect-swift/pull/49#discussion_r2036796813
########## Sources/SparkConnect/ErrorUtils.swift: ########## @@ -0,0 +1,36 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// +import Foundation + +/// Utility functions like `org.apache.spark.util.SparkErrorUtils`. +public enum ErrorUtils { + public static func tryWithSafeFinally<T>( + _ block: () async throws -> T, _ finallyBlock: () async throws -> Void + ) async rethrows -> T { + let result: T + do { + result = try await block() + try await finallyBlock() + } catch { + try await finallyBlock() Review Comment: Perhaps this is closer to the exception handling approach of `tryWithSafeFinally` in the Scala version? ########## Sources/SparkConnect/ErrorUtils.swift: ########## @@ -0,0 +1,36 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// +import Foundation + +/// Utility functions like `org.apache.spark.util.SparkErrorUtils`. +public enum ErrorUtils { + public static func tryWithSafeFinally<T>( + _ block: () async throws -> T, _ finallyBlock: () async throws -> Void + ) async rethrows -> T { + let result: T + do { + result = try await block() + try await finallyBlock() + } catch { + try await finallyBlock() Review Comment: ```suggestion try? await finallyBlock() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
