ueshin commented on PR #50537: URL: https://github.com/apache/spark/pull/50537#issuecomment-2790994804
@cloud-fan We need additional fix for this. For example, using the test [here](https://github.com/apache/spark/pull/50537/files#diff-adc3f627771dab40517626755090a97ce8d6ab3cec413b8fb88627e7049414e0R2834-R2839), ```scala sql("select a, b from (select a, b, struct(a, b) sab from l) " + "where sab IN (select struct(c, d) from r)").show() ``` fails with: ``` [info] java.lang.IllegalArgumentException: requirement failed: Join keys from two sides should have same length and types [info] at scala.Predef$.require(Predef.scala:337) [info] at org.apache.spark.sql.execution.joins.HashJoin.org$apache$spark$sql$execution$joins$HashJoin$$x$6(HashJoin.scala:115) [info] at org.apache.spark.sql.execution.joins.HashJoin.org$apache$spark$sql$execution$joins$HashJoin$$x$6$(HashJoin.scala:110) [info] at org.apache.spark.sql.execution.joins.BroadcastHashJoinExec.org$apache$spark$sql$execution$joins$HashJoin$$x$6$lzycompute(BroadcastHashJoinExec.scala:40) [info] at org.apache.spark.sql.execution.joins.BroadcastHashJoinExec.org$apache$spark$sql$execution$joins$HashJoin$$x$6(BroadcastHashJoinExec.scala:40) [info] at org.apache.spark.sql.execution.joins.HashJoin.buildKeys(HashJoin.scala:110) [info] at org.apache.spark.sql.execution.joins.HashJoin.buildKeys$(HashJoin.scala:110) [info] at org.apache.spark.sql.execution.joins.BroadcastHashJoinExec.buildKeys$lzycompute(BroadcastHashJoinExec.scala:40) [info] at org.apache.spark.sql.execution.joins.BroadcastHashJoinExec.buildKeys(BroadcastHashJoinExec.scala:40) [info] at org.apache.spark.sql.execution.joins.HashJoin.buildBoundKeys(HashJoin.scala:130) [info] at org.apache.spark.sql.execution.joins.HashJoin.buildBoundKeys$(HashJoin.scala:129) [info] at org.apache.spark.sql.execution.joins.BroadcastHashJoinExec.buildBoundKeys$lzycompute(BroadcastHashJoinExec.scala:40) [info] at org.apache.spark.sql.execution.joins.BroadcastHashJoinExec.buildBoundKeys(BroadcastHashJoinExec.scala:40) [info] at org.apache.spark.sql.execution.joins.BroadcastHashJoinExec.requiredChildDistribution(BroadcastHashJoinExec.scala:63) ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
