pan3793 commented on code in PR #50529:
URL: https://github.com/apache/spark/pull/50529#discussion_r2032467329
##########
dev/make-distribution.sh:
##########
@@ -124,32 +133,34 @@ if [ $(command -v git) ]; then
unset GITREV
fi
-
-if [ ! "$(command -v "$MVN")" ] ; then
- echo -e "Could not locate Maven command: '$MVN'."
- echo -e "Specify the Maven command with the --mvn flag"
- exit -1;
+if [ "$SBT_ENABLED" == "true" && ! "$(command -v "$SBT")" ]; then
+ echo -e "Could not locate SBT command: '$SBT'."
+ echo -e "Specify the SBT command with the --sbt flag"
+ exit -1;
+elif [ ! "$(command -v "$MVN")" ]; then
+ echo -e "Could not locate Maven command: '$MVN'."
+ echo -e "Specify the Maven command with the --mvn flag"
+ exit -1;
fi
-VERSION=$("$MVN" help:evaluate -Dexpression=project.version $@ \
- | grep -v "INFO"\
- | grep -v "WARNING"\
- | tail -n 1)
-SCALA_VERSION=$("$MVN" help:evaluate -Dexpression=scala.binary.version $@ \
- | grep -v "INFO"\
- | grep -v "WARNING"\
- | tail -n 1)
-SPARK_HADOOP_VERSION=$("$MVN" help:evaluate -Dexpression=hadoop.version $@ \
- | grep -v "INFO"\
- | grep -v "WARNING"\
- | tail -n 1)
-SPARK_HIVE=$("$MVN" help:evaluate -Dexpression=project.activeProfiles -pl
sql/hive $@ \
Review Comment:
`SPARK_HIVE` is not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
