anishshri-db commented on code in PR #50508: URL: https://github.com/apache/spark/pull/50508#discussion_r2029982670
########## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/FailureInjectionCheckpointFileManager.scala: ########## @@ -0,0 +1,254 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.execution.streaming.state + +import java.io._ +import java.net.URI + +import org.apache.hadoop.conf.Configuration +import org.apache.hadoop.fs._ +import org.apache.hadoop.fs.permission.FsPermission +import org.apache.hadoop.util.Progressable + +import org.apache.spark.internal.Logging +import org.apache.spark.sql.execution.streaming.CheckpointFileManager.{CancellableFSDataOutputStream, RenameBasedFSDataOutputStream} +import org.apache.spark.sql.execution.streaming.FileSystemBasedCheckpointFileManager + +/** + * A wrapper file output stream that will throw exception in close() and put the underlying + * stream to FailureInjectionFileSystem.delayedStreams + * @param stream stream to be wrapped + */ +class DelayCloseFSDataOutputStreamWrapper(stream: CancellableFSDataOutputStream) + extends CancellableFSDataOutputStream(stream.getWrappedStream) with Logging { + val originalStream: CancellableFSDataOutputStream = stream + + var closed: Boolean = false + + override def close(): Unit = { + if (!closed) { + closed = true + FailureInjectionFileSystem.delayedStreams = + FailureInjectionFileSystem.delayedStreams :+ originalStream + throw new IOException("Fake File Stream Close Failure") + } + } + + /** Cancel is not needed in unit tests */ + override def cancel(): Unit = {} +} + +/** + * A wrapper checkpoint file manager that might inject functions in some function calls. + * Used in unit tests to simulate failure scenarios. + * This can be put into SQLConf.STREAMING_CHECKPOINT_FILE_MANAGER_CLASS to provide failure + * injection behavior. + * + * @param path Review Comment: nit: you need to add comments for the args ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
