mihailom-db commented on code in PR #50465: URL: https://github.com/apache/spark/pull/50465#discussion_r2020830316
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ########## @@ -452,10 +458,16 @@ case class Except( private lazy val lazyOutput: Seq[Attribute] = computeOutput() /** We don't use right.output because those rows get excluded from the set. */ - private def computeOutput(): Seq[Attribute] = left.output Review Comment: Point of refactoring is to make Union, Except and Intersect follow similar patterns, as that will make reuse in single-pass Analyzer much easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
