cloud-fan commented on code in PR #50311:
URL: https://github.com/apache/spark/pull/50311#discussion_r2004542726
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -5490,7 +5490,7 @@ class AstBuilder extends DataTypeAstBuilder
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
val query = Option(ctx.query).map(plan)
- withIdentClause(ctx.identifierReference, query.toSeq, (ident, children) =>
{
Review Comment:
can we keep this part? I think it's still better to not hide any plan from
`PlanWithUnresolvedIdentifier`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
