HyukjinKwon commented on code in PR #50466:
URL: https://github.com/apache/spark/pull/50466#discussion_r2027862720


##########
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala:
##########
@@ -347,6 +348,8 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
     def writeNextInputToStream(dataOut: DataOutputStream): Boolean
 
     def open(dataOut: DataOutputStream): Unit = Utils.logUncaughtExceptions {
+      val isUnixDomainSock = 
authHelper.conf.get(PYTHON_UNIX_DOMAIN_SOCKET_ENABLED)
+      lazy val sockPath = new File(System.getProperty("user.home"), 
s".${UUID.randomUUID()}.sock")

Review Comment:
   The reason why I am using home address is that UDS restricts its maximum 
length to 104 bytes. It's OS level restriction so can't really work around. If 
you use the current working directory, it becomes a problem in Spark Connect 
because the current working directory changes for individual session for 
session isolation in Spark Connect.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to