aokolnychyi commented on code in PR #50496:
URL: https://github.com/apache/spark/pull/50496#discussion_r2027371940
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1519,6 +1533,62 @@ number
| MINUS? BIGDECIMAL_LITERAL #bigDecimalLiteral
;
+columnConstraintDefinition
+ : (CONSTRAINT name=errorCapturingIdentifier)? columnConstraint
constraintCharacteristic*
+ ;
+
+columnConstraint
+ : checkConstraint
+ | uniqueSpec
+ | referenceSpec
+ ;
+
+tableConstraintDefinition
+ : (CONSTRAINT name=errorCapturingIdentifier)? tableConstraint
constraintCharacteristic*
+ ;
+
+tableConstraint
+ : checkConstraint
+ | uniqueConstraint
+ | foreignKeyConstraint
+ ;
+
+checkConstraint
+ : CHECK LEFT_PAREN (expr=booleanExpression) RIGHT_PAREN
+ ;
+
+uniqueSpec
+ : UNIQUE
+ | PRIMARY KEY
+ ;
+
+uniqueConstraint
Review Comment:
Minor: It took me a while to find PK, it wasn't obvious it is part of
`uniqueSpec`. I would consider splitting them for clarity but also see that you
probably wanted to cut on the number rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
