micheal-o commented on code in PR #50502:
URL: https://github.com/apache/spark/pull/50502#discussion_r2026011925
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -516,7 +516,12 @@ class RocksDBFileManager(
logInfo(log"Estimated maximum version is " +
log"${MDC(LogKeys.MAX_SEEN_VERSION, maxSeenVersion.get)}" +
log" and minimum version is ${MDC(LogKeys.MIN_SEEN_VERSION,
minSeenVersion)}")
- val versionsToDelete = maxSeenVersion.get - minSeenVersion + 1 -
numVersionsToRetain
+ var versionsToDelete = maxSeenVersion.get - minSeenVersion + 1 -
numVersionsToRetain
Review Comment:
nit: why not just do `max(maxSeenVersion.get - minSeenVersion + 1 -
numVersionsToRetain, 0)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
