viirya commented on code in PR #50496: URL: https://github.com/apache/spark/pull/50496#discussion_r2025464724
########## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ########## @@ -1337,6 +1341,15 @@ colType : colName=errorCapturingIdentifier dataType (errorCapturingNot NULL)? commentSpec? ; +tableElementList + : tableElement (COMMA tableElement)* + ; + +tableElement + : tableConstraintDefinition + | colDefinition Review Comment: So `tableConstraintDefinition, tableConstraintDefinition` will be also parsed as `tableElementList`? I think it is required to be `colDefinition (tableConstraintDefinition)*` for each `tableElement`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org