anishshri-db commented on code in PR #50483:
URL: https://github.com/apache/spark/pull/50483#discussion_r2025256690


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -843,14 +843,16 @@ class RocksDBFileManager(
       }
       zout.close()  // so that any error in closing also cancels the output 
stream
       logInfo(log"Zipped ${MDC(LogKeys.NUM_BYTES, totalBytes)} bytes (before 
compression) to " +
-        log"${MDC(LogKeys.FILE_NAME, filesStr)}")
+        log"${MDC(LogKeys.FILE_NAME, dfsZipFile)}")
+      logDebug(log"Files are:\n\t${MDC(LogKeys.FILE_NAME, fileListStr)}")

Review Comment:
   Move whole line to debug



##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -865,7 +867,8 @@ class RocksDBFileManager(
     lazy val files = 
Option(Utils.recursiveList(dir)).getOrElse(Array.empty).map { f =>
       s"${f.getAbsolutePath} - ${f.length()} bytes"
     }
-    logInfo(msg + log" - ${MDC(LogKeys.NUM_FILES, files.length)} files\n\t" +
+    logInfo(msg + log" - ${MDC(LogKeys.NUM_FILES, files.length)} files")

Review Comment:
   Same here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to