eejbyfeldt commented on code in PR #41704:
URL: https://github.com/apache/spark/pull/41704#discussion_r2022701986
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala:
##########
@@ -806,25 +807,38 @@ object ScalaReflection extends ScalaReflection {
encoderFor(typeTag[E].in(mirror).tpe).asInstanceOf[AgnosticEncoder[E]]
}
+ /**
+ * Same as [[encoderFor]] but with extended support to return
[[UnboundRowEncoder]] for [[Row]]
+ * type.
+ */
+ def encoderForWithRowEncoderSupport[E: TypeTag]: AgnosticEncoder[E] = {
+ encoderFor(typeTag[E].in(mirror).tpe, isRowEncoderSupported = true)
Review Comment:
Is `isRowEncoderSupported` ever read? It looks to me like it just passed
around but never actually read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
