dongjoon-hyun commented on code in PR #50476:
URL: https://github.com/apache/spark/pull/50476#discussion_r2023578484
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormatSuite.scala:
##########
@@ -135,12 +135,17 @@ abstract class ParquetFileFormatSuite
test("Write and read back TIME values") {
Seq(false, true).foreach { offHeapEnabled =>
withSQLConf(SQLConf.COLUMN_VECTOR_OFFHEAP_ENABLED.key ->
offHeapEnabled.toString) {
- withTempPath { dir =>
- val data = Seq(LocalTime.parse("01:12:30.999999")).toDF("col")
- data.write.parquet(dir.getCanonicalPath)
- val readback = spark.read.parquet(dir.getCanonicalPath)
- assertResult(readback.schema) { new StructType().add("col",
TimeType()) }
- checkAnswer(readback, data)
+ val data = Seq(LocalTime.parse("01:12:30.999999")).toDF("col")
+ withNestedDataFrame(data).foreach { case (newDF, colName, _) =>
+ withTempPath { dir =>
+ newDF.write.parquet(dir.getCanonicalPath)
+ Seq(false, true).foreach { vectorizedReaderEnabled =>
Review Comment:
Thank you for improving this test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
