LuciferYang commented on code in PR #50474:
URL: https://github.com/apache/spark/pull/50474#discussion_r2022280683
##########
sql/api/src/main/scala/org/apache/spark/sql/MergeIntoWriter.scala:
##########
@@ -202,7 +202,7 @@ abstract class MergeIntoWriter[T] {
* @tparam T
* The type of data in the MergeIntoWriter.
*/
-case class WhenMatched[T] private[sql] (
+case class WhenMatched[T](
Review Comment:
Such a change has led to an enlargement of the access scope of the
constructor, which may not conform to the original intended expectations. Isn't
there a better alternative solution?
##########
project/SparkBuild.scala:
##########
@@ -229,6 +229,7 @@ object SparkBuild extends PomBuild {
lazy val compilerWarningSettings: Seq[sbt.Def.Setting[_]] = Seq(
(Compile / scalacOptions) ++= {
Seq(
+ "-Xsource:3-cross",
Review Comment:
Maven also needs to be fixed similarly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
