dejankrak-db commented on code in PR #50468:
URL: https://github.com/apache/spark/pull/50468#discussion_r2021781267
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveDDLCommandStringTypes.scala:
##########
@@ -66,6 +66,16 @@ object ResolveDDLCommandStringTypes extends
Rule[LogicalPlan] {
StringType(defaultCollation)
}
+ case alterViewAs: AlterViewAs =>
+ alterViewAs.child match {
+ case resolvedPersistentView: ResolvedPersistentView =>
+ val collation =
resolvedPersistentView.metadata.collation.getOrElse(defaultCollation)
+ StringType(collation)
+ case resolvedTempView: ResolvedTempView =>
+ val collation =
resolvedTempView.metadata.collation.getOrElse(defaultCollation)
+ StringType(collation)
Review Comment:
Should we, similar as in AlterTableCommand, add a default case, as a
safeguard for unknown cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
