LuciferYang commented on code in PR #50463:
URL: https://github.com/apache/spark/pull/50463#discussion_r2020726525
##########
sql/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/connect/UDFClassLoadingE2ESuite.scala:
##########
@@ -21,7 +21,7 @@ import java.nio.file.{Files, Paths}
import scala.util.Properties
-import com.google.protobuf.ByteString
+import org.sparkproject.connect.protobuf.ByteString
Review Comment:
What concerns me is this part. I feel like it might bring extra trouble to
sbt.
##########
sql/connect/client/integration-tests/src/test/scala/org/apache/spark/sql/connect/UDFClassLoadingE2ESuite.scala:
##########
@@ -21,7 +21,7 @@ import java.nio.file.{Files, Paths}
import scala.util.Properties
-import com.google.protobuf.ByteString
+import org.sparkproject.connect.protobuf.ByteString
Review Comment:
What concerns me is this part. I feel like it might bring extra trouble to
sbt build and test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
