robreeves opened a new pull request, #50452:
URL: https://github.com/apache/spark/pull/50452
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
This improves the handling when MDC is not supported.
### Why are the changes needed?
In https://github.com/apache/spark/pull/35141 it added handling to
gracefully handle when MDC is not available. It catches NoSuchFieldError, which
is thrown during MDC initialization. This will work for the first task. If a
second task runs it will not throw a NoSuchFieldError. Instead it throws
NoClassDefFoundError. Then the job will hang indefinitely. This improves the
fix so it works for all tasks instead of just the first one.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, it fixes a bug. It also changes a log message to include the exception
for easier debugging.
### How was this patch tested?
I tested it manually in spark-shell by manually throwing `NoSuchFieldError`.
It logs this message and does not hang.
```
25/03/28 14:11:48 INFO Executor: MDC is not supported.
java.lang.NoSuchFieldError: this is a test
at org.apache.spark.executor.Executor.liftedTree1$1(Executor.scala:118)
at
org.apache.spark.executor.Executor.mdcIsSupported$lzycompute(Executor.scala:114)
at org.apache.spark.executor.Executor.mdcIsSupported(Executor.scala:113)
at
org.apache.spark.executor.Executor.org$apache$spark$executor$Executor$$setMDCForTask(Executor.scala:948)
at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:584)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
```
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
