attilapiros commented on PR #50439:
URL: https://github.com/apache/spark/pull/50439#issuecomment-2762330162

   > Since this is a regression, could you make an independent test case 
instead of adding to the existing `SPARK-25888` test case, @attilapiros ?
   
   We can duplicate the test but actually these checks were really missing from 
the old test ("SPARK-25888: using external shuffle service fetching disk 
persisted blocks") 
   + 
   We will double/quadruple the runtime as any test we add runs in 2 times 
(ExternalShuffleServiceSuite&SslExternalShuffleServiceSuite instance):
   ```
   [info] ExternalShuffleServiceSuite:
   [info] - SPARK-25888: using external shuffle service fetching disk persisted 
blocks (15 seconds, 358 milliseconds)
   [info] SslExternalShuffleServiceSuite:
   [info] - SPARK-25888: using external shuffle service fetching disk persisted 
blocks (14 seconds, 270 milliseconds)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to