cloud-fan commented on code in PR #50409: URL: https://github.com/apache/spark/pull/50409#discussion_r2017839140
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ########## @@ -4187,3 +4189,18 @@ object RemoveTempResolvedColumn extends Rule[LogicalPlan] { } } } + +/** + * Rule that's used to handle `UnresolvedHaving` nodes with resolved `condition` and `child`. + * It's placed in the `Once` batch to avoid conflicts with other rules that resolve Review Comment: ```suggestion * It's placed outside of the main batch to avoid conflicts with other rules that resolve ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org