vicennial commented on code in PR #50334:
URL: https://github.com/apache/spark/pull/50334#discussion_r2015850636
##########
core/src/test/scala/org/apache/spark/executor/ClassLoaderIsolationSuite.scala:
##########
@@ -109,4 +109,31 @@ class ClassLoaderIsolationSuite extends SparkFunSuite with
LocalSparkContext {
}
}
}
+
+ test("SPARK-51537 Executor isolation session classloader inherits from " +
Review Comment:
Is there a way we can also add a test (here or elsewhere) for the plugin
issue?
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -1096,33 +1100,41 @@ private[spark] class Executor(
)
if (useStub) {
- createClassLoaderWithStub(urls,
conf.get(CONNECT_SCALA_UDF_STUB_PREFIXES))
+ createClassLoaderWithStub(urls,
conf.get(CONNECT_SCALA_UDF_STUB_PREFIXES), isDefaultSession)
} else {
- createClassLoader(urls)
+ createClassLoader(urls, isDefaultSession)
}
}
- private def createClassLoader(urls: Array[URL]): MutableURLClassLoader = {
+ private def createClassLoader(urls: Array[URL],
+ isDefaultSession: Boolean):
MutableURLClassLoader = {
+ // SPARK-51537, The isolation session must "inherit" the classloader from
default session which
+ // has already added the global jars specified by --jars
Review Comment:
For sake of completeness/tracking, please also add the short blurb about the
plugin issue here and the other comment below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
