HyukjinKwon commented on code in PR #50368:
URL: https://github.com/apache/spark/pull/50368#discussion_r2015842606
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -352,8 +352,9 @@ case class AdaptiveSparkPlanExec(
val newCost = costEvaluator.evaluateCost(newPhysicalPlan)
if (newCost < origCost ||
(newCost == origCost && currentPhysicalPlan != newPhysicalPlan)) {
- logOnLevel("Plan changed:\n" +
- sideBySide(currentPhysicalPlan.treeString,
newPhysicalPlan.treeString).mkString("\n"))
Review Comment:
hmmm .. I think we should actually make `Logging.logTrace` call by value so
the inside ones are not evaluated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
