LuciferYang commented on code in PR #47402:
URL: https://github.com/apache/spark/pull/47402#discussion_r2010059824
##########
assembly/pom.xml:
##########
@@ -109,6 +109,16 @@
<version>${project.version}</version>
<scope>provided</scope>
</dependency>
+ <!--
+ Included so Spark Connect client was compiled before triggering assembly.
Review Comment:
For Record: It is precisely because the `Spark Connect client was compiled
before triggering assembly` that if we directly execute
```
build/mvn clean install -Phive -Pxxx
```
instead of
```
build/mvn clean install -Phive -Pxxx -DskipTests
build/mvn test -pl sql/connect/client/jvm // like maven daily test
```
the Spark Connect client module will not be able to testing using Maven.
This is because the test cases related to `RemoteSparkSession` in this module
rely on the `assembly` module to collect dependencies beforehand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
