ueshin commented on code in PR #50341:
URL: https://github.com/apache/spark/pull/50341#discussion_r2006954377
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala:
##########
@@ -173,7 +173,7 @@ object ExtractPythonUDFs extends Rule[LogicalPlan] with
Logging {
private def canEvaluateInPython(e: PythonUDF): Boolean = {
e.children match {
// single PythonUDF child could be chained and evaluated in Python
- case Seq(u: PythonUDF) => e.evalType == u.evalType &&
canEvaluateInPython(u)
+ case Seq(u: PythonUDF) => correctEvalType(e) == correctEvalType(u) &&
canEvaluateInPython(u)
Review Comment:
I guess we can, but I feel it's too much .. as this fallback should be
temporary, and we should support UDTs with Arrow-optimized Python UDFs soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
