aokolnychyi commented on code in PR #50271:
URL: https://github.com/apache/spark/pull/50271#discussion_r2008260823


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryRowLevelOperationTableCatalog.scala:
##########
@@ -43,4 +43,27 @@ class InMemoryRowLevelOperationTableCatalog extends 
InMemoryTableCatalog {
     namespaces.putIfAbsent(ident.namespace.toList, Map())
     table
   }
+
+  override def alterTable(ident: Identifier, changes: TableChange*): Table = {

Review Comment:
   The challenge is that each table implementation `InMemoryTable`, 
`InMemoryRowLevelOperationTable`, and others have different constructor 
parameters. It didn't seem worth complicating the base class but I can look 
into that if there are good ideas.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to