cloud-fan commented on code in PR #50325:
URL: https://github.com/apache/spark/pull/50325#discussion_r2007027831
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveIdentifierClause.scala:
##########
@@ -34,17 +36,68 @@ class ResolveIdentifierClause(earlyBatches:
Seq[RuleExecutor[LogicalPlan]#Batch]
override def batches: Seq[Batch] = earlyBatches.asInstanceOf[Seq[Batch]]
}
- override def apply(plan: LogicalPlan): LogicalPlan =
plan.resolveOperatorsUpWithPruning(
- _.containsPattern(UNRESOLVED_IDENTIFIER)) {
+ override def apply(plan: LogicalPlan): LogicalPlan = {
+ val referredTempVars = new mutable.ArrayBuffer[Seq[String]]
+ val analyzedPlan = apply0(plan, referredTempVars)
+
+ analyzedPlan match {
+ case createView: CreateView =>
+ if (createView.referredTempVar.isDefined) {
+ createView
+ } else if (referredTempVars.isEmpty) {
+ createView
+ } else {
+ createView.copy(referredTempVar = Some(referredTempVars.head))
Review Comment:
why do we put it back to `CreateView`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
