zhengruifeng opened a new pull request, #50332:
URL: https://github.com/apache/spark/pull/50332
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Fix ThreadPoolExecutor failure in python 3.13 daily build
### Why are the changes needed?
in the last 3 weeks, python 3.13 daily build is keep failing with
```
File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line
1823, in _handle_error
raise error
File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line
1534, in _execute_and_fetch_as_iterator
for b in generator:
^^^^^^^^^
File "<frozen _collections_abc>", line 360, in __next__
File "/__w/spark/spark/python/pyspark/sql/connect/client/reattach.py",
line 146, in send
self._release_all()
~~~~~~~~~~~~~~~~~^^
File "/__w/spark/spark/python/pyspark/sql/connect/client/reattach.py",
line 241, in _release_all
self._release_thread_pool.submit(target)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
File "/usr/lib/python3.13/concurrent/futures/thread.py", line 171, in
submit
raise RuntimeError('cannot schedule new futures after shutdown')
RuntimeError: cannot schedule new futures after shutdown
```
In `ThreadPoolExecutor.submit`, this only happens when the pool is already
shutdown:
```
def submit(self, fn, /, *args, **kwargs):
with self._shutdown_lock, _global_shutdown_lock:
if self._broken:
raise BrokenThreadPool(self._broken)
if self._shutdown:
raise RuntimeError('cannot schedule new futures after
shutdown')
if _shutdown:
raise RuntimeError('cannot schedule new futures after '
'interpreter shutdown')
f = _base.Future()
w = _WorkItem(f, fn, args, kwargs)
self._work_queue.put(w)
self._adjust_thread_count()
return f
```
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
PR builder with
```
default: '{"PYSPARK_IMAGE_TO_TEST": "python-313", "PYTHON_TO_TEST":
"python3.13"}'
```
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
