adrians commented on code in PR #50170: URL: https://github.com/apache/spark/pull/50170#discussion_r2000685345
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala: ########## @@ -298,6 +299,24 @@ object ReorderAssociativeOperator extends Rule[LogicalPlan] { } +/** + * The "ArrayContains" node checks if a given value is present in a given array, + * being similar to the "IN" predicate. Review Comment: Sure, I'll add some test-cases to validate the behaviour for edge-cases. Thank your for the feedback. My first priority was to get a confirmation that the change is viable for merging upstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org