LuciferYang commented on code in PR #48937: URL: https://github.com/apache/spark/pull/48937#discussion_r1998655871
########## bin/load-spark-env.sh: ########## @@ -65,6 +65,6 @@ export SPARK_SCALA_VERSION=2.13 #fi # Append jline option to enable the Beeline process to run in background. -if [[ ( ! $(ps -o stat= -p $$) =~ "+" ) && ! ( -p /dev/stdin ) ]]; then +if [ -e /usr/bin/tty -a "`tty`" != "not a tty" -a ! -p /dev/stdin ]; then Review Comment: ref https://github.com/koalaman/shellcheck/wiki/SC2166 and https://github.com/koalaman/shellcheck/wiki/SC2006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
