dongjoon-hyun commented on code in PR #17:
URL:
https://github.com/apache/spark-connect-swift/pull/17#discussion_r1994561481
##########
Sources/SparkConnect/SparkConnectClient.swift:
##########
@@ -275,9 +275,11 @@ public actor SparkConnectClient {
let expressions: [Spark_Connect_Expression.SortOrder] = cols.map {
var expression = Spark_Connect_Expression.SortOrder()
expression.child.exprType =
.unresolvedAttribute($0.toUnresolvedAttribute)
+ expression.direction = .ascending
return expression
}
sort.order = expressions
+ sort.isGlobal = true
Review Comment:
I piggy-back this fix while checking a test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
