zecookiez commented on code in PR #50123:
URL: https://github.com/apache/spark/pull/50123#discussion_r1992458658
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -2236,6 +2236,19 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val STATE_STORE_COORDINATOR_MIN_SNAPSHOT_VERSION_DELTA_TO_LOG =
+ buildConf("spark.sql.streaming.stateStore.minSnapshotVersionDeltaToLog")
+ .internal()
+ .doc(
+ "Minimum number of versions between the most recent uploaded snapshot
version of a " +
+ "single state store instance and the most recent version across all
state store " +
+ "instances to log a warning message."
+ )
+ .version("4.0.0")
+ .intConf
+ .checkValue(k => k >= 0, "Must be greater than or equal to 0")
Review Comment:
Good point, if it's 0 it will just report every instance as lagging which
doesn't seem ideal. I will add another config to enable/disable these event
reports to the coordinator 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
