dongjoon-hyun commented on code in PR #15:
URL:
https://github.com/apache/spark-connect-swift/pull/15#discussion_r1992468989
##########
Tests/SparkConnectTests/RuntimeConfTests.swift:
##########
@@ -31,7 +31,7 @@ struct RuntimeConfTests {
_ = try await client.connect(UUID().uuidString)
let conf = RuntimeConf(client)
- #expect(try await conf.get("spark.app.name") == "Spark Connect server")
+ #expect(try await conf.get("spark.app.name") != nil)
Review Comment:
This makes the test more robust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
