LuciferYang commented on code in PR #50187:
URL: https://github.com/apache/spark/pull/50187#discussion_r1991901327
##########
connect-examples/server-library-example/pom.xml:
##########
@@ -36,7 +36,8 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<scala.binary>2.13</scala.binary>
<scala.version>2.13.15</scala.version>
- <protobuf.version>3.25.4</protobuf.version>
- <spark.version>4.0.0-preview2</spark.version>
+ <protobuf.version>4.29.3</protobuf.version>
+ <spark.version>4.1.0-SNAPSHOT</spark.version>
+ <connect.guava.version>33.4.0-jre</connect.guava.version>
Review Comment:
If feasible, it's certainly ok. However, I have a few questions regarding
this:
1. How should the version numbers of other dependencies be updated? Do they
need to be consistent with Spark? For instance, the current Spark uses Scala
2.13.16, but this project is still using 2.13.15.
2. During the release process, after changing the Spark version (e.g., from
4.0.0-SNAPSHOT to 4.0.0), is it necessary to check the `build` of this project?
3. Since it aims to be independent project, why don't we choose to maintain
this examples project in a separate branch(no Spark code whatsoever), or even
create a separate repository like `spark-connect-examples`? If it is an
independent repository, would it be more convenient to also include examples
for clients in other programming languages, such as Go or Swift?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
