wForget commented on code in PR #50245:
URL: https://github.com/apache/spark/pull/50245#discussion_r1990969615
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala:
##########
@@ -459,11 +459,28 @@ object TableOutputResolver extends SQLConfHelper with
Logging {
}
if (resKey.length == 1 && resValue.length == 1) {
- val keyFunc = LambdaFunction(resKey.head, Seq(keyParam))
- val valueFunc = LambdaFunction(resValue.head, Seq(valueParam))
- val newKeys = ArrayTransform(MapKeys(nullCheckedInput), keyFunc)
- val newValues = ArrayTransform(MapValues(nullCheckedInput), valueFunc)
- Some(Alias(MapFromArrays(newKeys, newValues), expected.name)())
+ // If the key and value expressions have not changed, we just check
original map field.
+ // Otherwise, we construct a new map by adding transformations to the
keys and values.
+ if (resKey.head == keyParam && resValue.head == valueParam) {
+ Some(
+ Alias(nullCheckedInput, expected.name)(
+ nonInheritableMetadataKeys =
+ Seq(CharVarcharUtils.CHAR_VARCHAR_TYPE_STRING_METADATA_KEY)))
Review Comment:
I just want to be consistent with #47843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
